Make multi scalar multiplication generic on the size of the Scalar #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
changed the title
CPerezz
reviewed
Oct 30, 2023
| @@ -40,7 +40,7 @@ fn multiexp_serial<C: CurveAffine>(coeffs: &[C::Scalar], bases: &[C], acc: &mut | |||
| let skip_bits = segment * c; | |||
| let skip_bytes = skip_bits / 8; | |||
|
|
|||
| if skip_bytes >= 32 { | |||
| if skip_bytes >= (F::NUM_BITS as usize + 7) / 8 { | |||
There was a problem hiding this comment.
Suggested change
| if skip_bytes >= (F::NUM_BITS as usize + 7) / 8 { | |
| if skip_bytes >= (F::NUM_BITS as usize + 7) >> 3 { |
| @@ -122,7 +122,7 @@ pub fn small_multiexp<C: CurveAffine>(coeffs: &[C::Scalar], bases: &[C]) -> C::C | |||
| let mut acc = C::Curve::identity(); | |||
|
|
|||
| // for byte idx | |||
| for byte_idx in (0..32).rev() { | |||
| for byte_idx in (0..((C::Scalar::NUM_BITS as usize + 7) / 8)).rev() { | |||
There was a problem hiding this comment.
Suggested change
| for byte_idx in (0..((C::Scalar::NUM_BITS as usize + 7) / 8)).rev() { | |
| for byte_idx in (0..((C::Scalar::NUM_BITS as usize + 7) >> 3)).rev() { |
davidnevadoc
approved these changes
Oct 30, 2023
han0110
approved these changes
Oct 31, 2023
iquerejeta
added a commit
to input-output-hk/halo2
that referenced
this pull request
Dec 13, 2023
iquerejeta
added a commit
to input-output-hk/halo2
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-scalar multiplication algorithms in halo2 are written for scalars of 32 bytes. This PR uses generics (
NUM_BITS) to make the algorithm generic over larger Scalar fields (such as those of Pluto/Eris curves).